Re: git: cc9c37d73947 - main - */*: Always use WRK_ENV with SETENVI

Hello Tijl,

On Sun, Mar 24, 2024 at 1:47 AM Tijl Coosemans <tijl@freebsd.org> wrote:

> The branch main has been updated by tijl:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=cc9c37d73947e0184f66f0b5fa3fc021f7fdf51c
>
> commit cc9c37d73947e0184f66f0b5fa3fc021f7fdf51c
> Author:     Tijl Coosemans <tijl@FreeBSD.org>
> AuthorDate: 2024-03-23 17:35:13 +0000
> Commit:     Tijl Coosemans <tijl@FreeBSD.org>
> CommitDate: 2024-03-23 17:45:45 +0000
>
>     */*: Always use WRK_ENV with SETENVI
>
>     WRK_ENV contains environment variables like OSVERSION and UNAME_* that
>     are needed when cross-building packages using Poudriere for a different
>     version of FreeBSD or a different architecture than that of the host
>     system.


It's just my 2 cents.

If SETENVI and WRK_ENV always come together, it would be better to have a
new
knob for it (e.g. SET_BASIC_ENV, SET_COMMON_ENV or SET_MIN_ENV). Therefore
we
won't use only part of them. The side benefit is it's shorter.

Since WRK_ENV contains a minimal set of common environment variables, could
we
rename it to a more intuitive name such as COMMON_ENV or something like
that?

Regards,
sunpoet