Re: git: 72ad532057c9 - main - archivers/zstd: Add CMake config files and adjust Makefile

On 05/04/23 08:15, Daniel Engberg wrote:
> The branch main has been updated by diizzy:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=72ad532057c9f9fb6fa370c80f663c005e9dd021
> 
> commit 72ad532057c9f9fb6fa370c80f663c005e9dd021
> Author:     Daniel Engberg <diizzy@FreeBSD.org>
> AuthorDate: 2023-04-05 06:12:08 +0000
> Commit:     Daniel Engberg <diizzy@FreeBSD.org>
> CommitDate: 2023-04-05 06:12:14 +0000
> 
>      archivers/zstd: Add CMake config files and adjust Makefile
>      
>      - Use upstream's short test for "make test"
>      - Use verbose output by default during build
>      * Tweak Makefile to follow Porters Handbook more closely
>      * Install CMake files (taken from CMake build framework)
>      
>      PR:             267652
>      Reported by:    fluffy
>      Approved by:    portmgr (maintainer timeout, 1+ month)

Hi,

Looks like this, unlickely, causes a failure with 
devel/qt6-base(abridged error, full log if needed):


ld: error: relocation R_X86_64_32 cannot be used against local symbol; 
recompile with -fPIC
 >>> defined in /usr/local/lib/libzstd.a(zstd_common.o)
 >>> referenced by zstd_common.c
 >>>               zstd_common.o:(ZSTD_versionString) in archive 
/usr/local/lib/libzstd.a

ld: error: relocation R_X86_64_32 cannot be used against local symbol; 
recompile with -fPIC
 >>> defined in /usr/local/lib/libzstd.a(error_private.o)
 >>> referenced by error_private.c
 >>>               error_private.o:(ERR_getErrorString) in archive 
/usr/local/lib/libzstd.a

ld: error: relocation R_X86_64_32S cannot be used against local symbol; 
recompile with -fPIC
 >>> defined in /usr/local/lib/libzstd.a(error_private.o)
 >>> referenced by error_private.c
 >>>               error_private.o:(ERR_getErrorString) in archive 
/usr/local/lib/libzstd.a

ld: error: relocation R_X86_64_32 cannot be used against local symbol; 
recompile with -fPIC
 >>> defined in /usr/local/lib/libzstd.a(error_private.o)
 >>> referenced by error_private.c
 >>>               error_private.o:(ERR_getErrorString) in archive 
/usr/local/lib/libzstd.a

...


I'm posting this as an early warning, I have had no time to investigate 
further.

-- 
Guido Falsi <madpilot@FreeBSD.org>